backport: Fix a crash in the minitest rewriter#235
Merged
varungandhi-src merged 1 commit intoscip-ruby/masterfrom Feb 20, 2025
Merged
backport: Fix a crash in the minitest rewriter#235varungandhi-src merged 1 commit intoscip-ruby/masterfrom
varungandhi-src merged 1 commit intoscip-ruby/masterfrom
Conversation
Original patch: sorbet/sorbet#8446 --- Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
varungandhi-src
force-pushed
the
vg_fix-crash
branch
from
21f890d to
dea1e47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original patch: sorbet/sorbet#8446
We haven't been able to sync with Sorbet upstream in a while.
Just backporting this patch is lower risk compared to doing
a full sync for fixing the immediate issue. I will file a follow-up
issue for updating the Sorbet version.
Fixes GRAPH-1096.
Motivation
Fixes crashes in the Minitest DSL.
Test plan
Same tests as original upstream PR.